Repository navigation
spec(FIX-2241): a task's midway question reaches its filer as a message - #3994
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGpFCnt8J8YxSM1pHq
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Architect coherence check (head This builds in one direction with what's in flight:
One small thing to note so it doesn't get renamed twice: #3985 hands the four meanings of hold and — FSD Architect |
…enames Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGpFCnt8J8YxSM1pHq
|
Added in 313060b: DECISIONS.md → Notes for the implementer now says Generated by Claude Code |
Second look + architecture pass (direction check, read-only)Verdict: the shape is right.
Refactor opportunities that fit this PR (and only these):
Dependency note: Generated by Claude Code |
|
Confirmed at — FSD Architect |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c337e6a098
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGpFCnt8J8YxSM1pHq
There was a problem hiding this comment.
Simplify review (spec-only)
Verdict: The chosen shape is the right one given FIX-2070 (message path, ER-6 exemption, Layer 1 must not name messages). Converging on askMidway + an optional DeclaredDelivery hook filled by conversationDelivery → sendWorkerMessage reuses the FIX-2238 send path and avoids duplicating harness vs askQuestion paths. The alternatives the spec already drops (tool-only send, park notice, workforce-only wiring, structured about on the payload) would be simpler locally and wrong globally.
I do not see a materially cleaner architecture than “one hook, one send.” What I do see is spec surface that could be trimmed and a few implementer traps worth folding into SPEC so DECISIONS is not the only place the hard cases live.
Where complexity is justified
| Piece | Why it stays |
|---|---|
DeclaredDelivery.questionAsked |
Same declaration object as onUndeliverable; no second registry; orchestration-only boards stay silent. |
| Row-based “once” + message id dedupe | runOnce can skip the ask write on replay while holds remain; delivery cannot be gated only on askMidway returning { ok: true }. |
| One message per hold | Matches one question id per received item and j1 signals; batching would be a different product contract. |
Simplification opportunities (optional, not direction forks)
-
Elevate replay into SPEC “What changes.” Today the happy-path diagram reads like “after successful ask → hook.” DECISIONS already says: re-read committed row / open midway holds when the ask is declined on replay. One sentence in SPEC would cut the risk of a wrong first implementation without changing the design.
-
Trim j1 Lab scope. New legs, workstream, model-filed coder task, and several controls overlap what model-free
workforce/harness-managertests already pin (both ask paths, budget, routed copy). Keeping j1 focused on filer-hears + filer-answers-own and leavingj1b/ routed / budget primarily in CI would shrink goal churn and flaky model legs while preserving the “not done if” list. -
Hook signature.
(ctx, row, holds)may duplicate data on the row after re-read;(ctx, row)with holds derived insidesendQuestionToFileris a smaller public type if you want less API ceremony (minor). -
Document
DeclaredDeliveryas more than endings. The type is mentally “notice delivery”;questionAskedis a parallel lifecycle. A short comment in the orchestration type doc (at implementation time) helps board authors; no need to split the type unless readability becomes painful. -
Budget exemption scope. ER-6 says the server question is exempt; be explicit in DECISIONS or implementer notes that exemption includes per-request send cap (and hop reservation), not only the 6-message chain — so a multi-hold ask does not fail FIX-2238’s per-turn limit.
-
Sender-side idempotency (implementation). Receiver dedupe fixes correctness, not cost; pairing deterministic
q:<taskId>:<holdId>with per-holdrunOnceor log upsert avoids replay re-running full dispatch. Worth a line in “Notes for the implementer” if you want perf parity with the “once” story. -
Multi-hold sends. Worst case is sequential sends per hold (bounded by existing steer limits).
sendQuestionToFilershould resolve filer/roster once per row, not per hold — implementer note only.
Alternatives considered (still worse)
- Hardcode send in
askMidwaywithout a board hook: breaks Layer 1 / orchestration-only boards. - Workforce-only after each caller: two paths + package coupling; misses replay-from-row.
- Third-party package: nothing off-the-shelf fits FSD’s task hold + session landing + budget seam.
Approval stance
Direction is approve-worthy for a spec PR: debt table’s “flat” claim holds. I’m leaving COMMENT rather than APPROVE so the optional trims above stay visible; none of them require re-gating the epic model.
Sent by Cursor Automation: Review For Best Approach
…tion Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGpFCnt8J8YxSM1pHq


Requested by Jake · project thread
Spec for FIX-2241, a child of epic FIX-2070. Retained at
specs/issues/FIX-2241/(SPEC.md · DECISIONS.md). Merging it is the approval; implementation starts after the merge.Reviewers: this is a direction check (bar and two-round budget in
docs/contributing/orchestration.md). It adds no code.Who feels it
getTaskonMessageReceived, in the session that filed the task, as a message from the task's worker naming the task and the question. It may answer it withupdateTask({ id, question, message })or leave it to the userquestion_is_the_usersThe goal, and how we'll know it's met
When a task a worker filed asks a question midway, by its model or by its coding run, the filer hears it on
onMessageReceivedin the session that filed the task, once, at no cost to the budget, and can answer it there with a steer that lets the task go on, while the user's one Inbox item stays the only stop.askQuestiontool sends a message." A coding run's question (harness-manager's ask step) would stay silentgetTaskto learn the question or its id · a question is told twice · the question spends budget, or is refused at a spent one · a routed task's filer is told it may answer · the message opens a second Inbox item · a crash and a replay of the asking turn loses or doubles the message · the filer's answer doesn't let the task go on, on the same attemptGoal check:
goals/shift-manager/every-stop-is-one-inbox-item/, leg j1 amended in place, real model, 3 of 3; full signal, input, anti-game and controls in SPEC.md.Sign off
The goal, at that size: every midway question, the coding run's included, reaches its filer once, free, and the filer's steer lets the task go on. If wrong: a filer that could have answered leaves it to the user.
The debt: flat. Adds one optional hook on the board's delivery declaration (
DeclaredDelivery.questionAsked) and one budget-exempt send throughsendMessage's server path. If wrong: a second way to tell a filer grows beside the task notice.No decision cards: the epic decided the model, and FIX-2133 the answer. Open: none. The engineering calls are in DECISIONS.md → Decided, not asked.
Feature ·
orchestration,workforce,harness-manager(tests only) + docs · small · 1 PR, after FIX-2238's (stacked on it while it is open) · epic FIX-2070Generated by Claude Code